search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
6.04k stars 1.14k forks source link

Optimize `lower()/upper()` string function with ASCII fast path #12365

Open 2010YOUY01 opened 4 weeks ago

2010YOUY01 commented 4 weeks ago

Is your feature request related to a problem or challenge?

Part of https://github.com/apache/datafusion/issues/12306

https://github.com/apache/datafusion/issues/12306 has introduced the rationale for ASCII fast path in detail

This optimization has already been implemented on char_length() string function and got some performance improvement (In PR https://github.com/apache/datafusion/pull/12356)

Describe the solution you'd like

Implement ASCII fast path for lower() and upper() function

Describe alternatives you've considered

No response

Additional context

No response

tshauck commented 4 weeks ago

take

thinh2 commented 5 days ago

Hi @tshauck, are you working on this issue?

tshauck commented 2 days ago

@thinh2 Sorry to leave you hanging. I got started but got busy. If you want to work on it, by all means.