search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
5.99k stars 1.13k forks source link

Add insert_or_update and get_payloads methods to binary_map/binary_view_map #12594

Open dmitrybugakov opened 4 days ago

dmitrybugakov commented 4 days ago

Is your feature request related to a problem or challenge?

Currently, in the datafusion-functions-extra repository, we have copied binary_map and binary_view_map from DataFusion. However, the insert_or_updateand get_payloads methods are missing from the original binary_map and binary_view_map implementations in DataFusion.

To avoid code duplication and ensure that these methods are available in the original DataFusion project, it would be beneficial to move these methods to the core DataFusion repository.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

dmitrybugakov commented 4 days ago

take

jayzhan211 commented 3 days ago

in the datafusion-functions-extra repository, we have copied binary_map and binary_view_map

Is there any reason why can't we just import from datafusion but require copying the code?

dmitrybugakov commented 2 days ago

The reason we copied the map instead of importing directly from DataFusion is that the version in datafusion-functions-extra includes two additional methods. To avoid waiting for the next DataFusion release, we copied the map and added those methods locally.

https://github.com/apache/datafusion/pull/12385#issuecomment-2364555142