Closed alamb closed 2 days ago
I think this one is also relatively straightforward and would make a good first project for someone skilled in Rust who wanted to get experience with the Datafusion codebase and tests
take
Convert BuiltInScalarFunction::{NthValue} -> Convert BuiltInWindowFunction::{NthValue}
Convert BuiltInScalarFunction::{NthValue} -> Convert BuiltInWindowFunction::{NthValue}
🤦 -- fixed
Hi, @dharanad . If you are busy can I look into this !
Hi, @dharanad . If you are busy can I look into this !
Sure
take
Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/8709
There is now no difference between "built in" / "prepackaged" scalar and aggregate functions in DataFusion, however there are still some "built in" window functions -- see the current source for
BuiltInWindowFunction
for the up to date list of what remainsThe problem with having two different kinds of window functions is
Describe the solution you'd like
I would like to remove the "built in" version of this function and convert it to a user defined function
Describe alternatives you've considered
At a high level the process is:
functions-window
crateBuiltInWindowFunction
variant and then get everything to compile (the compiler will show you where the existing implementations are)Additional context
Here are some good examples:
RowNumber
in https://github.com/apache/datafusion/pull/12030