apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
6.16k stars 1.16k forks source link

Deprecate `LogicalPlan::CrossJoin` #13057

Open Dandandan opened 1 day ago

Dandandan commented 1 day ago

Is your feature request related to a problem or challenge?

After https://github.com/apache/datafusion/pull/12985 we don't generate LogicalPlan::CrossJoin in the planner. It would be good to deprecate / remove this in the future.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

ding-young commented 2 hours ago

take

buraksenn commented 2 hours ago

Sorry @ding-young , I've already started working on this before typing take and just opened a PR.

ding-young commented 2 hours ago

@buraksenn Ohh I see. Thank you for letting me know.

buraksenn commented 1 hour ago

take