Open alamb opened 4 hours ago
While reviewing https://github.com/apache/datafusion/pull/12996 I noticed that all the implementations of GroupColumn for different types were in datafusion/physical-plan/src/aggregates/group_values/group_column.rs which is:
GroupColumn
datafusion/physical-plan/src/aggregates/group_values/group_column.rs
GroupValuesColumn
I would like to propose rearrainging the code:
primitive.rs
bytes.rs
No response
Once https://github.com/apache/datafusion/pull/12996 is merged, this would be a good first issue I think as it is just code movement and somewhat mechanical It would be a good way to get introduced to the code
Is your feature request related to a problem or challenge?
While reviewing https://github.com/apache/datafusion/pull/12996 I noticed that all the implementations of
GroupColumn
for different types were indatafusion/physical-plan/src/aggregates/group_values/group_column.rs
which is:GroupValuesColumn
: https://github.com/apache/datafusion/blob/main/datafusion/physical-plan/src/aggregates/group_values/column.rs#L94-L93Describe the solution you'd like
I would like to propose rearrainging the code:
primitive.rs
,bytes.rs
, etc)Describe alternatives you've considered
No response
Additional context
No response