search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
6.28k stars 1.19k forks source link

Revisit `bit_length` Not Supporting Utf8View Array. #13329

Open austin362667 opened 3 days ago

austin362667 commented 3 days ago

Describe the bug

As mentioned in this (ongoing) PR, we have added utf8view support for the bit_length scalar function, as well as for the bit_length array function in this (merged) PR. So, this sql logic test error should be resolved after upgrading to the corresponding version of arrow-rs.

To Reproduce

No response

Expected behavior

query I
select bit_length(column1_utf8view) from test;
----
48
72
56
0
NULL

Additional context

Thanks for @goldmedal 's suggestion to track on this issue: https://github.com/apache/datafusion/pull/13221#discussion_r1828563378

goldmedal commented 2 days ago

I added https://github.com/apache/datafusion/pull/13336 to enhance the coverage. When solving this issue, we can move those tests to string_query.slt.part.

austin362667 commented 2 days ago

That's great! Thank you @goldmedal