apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
6.37k stars 1.2k forks source link

Add utf8view support in nullif #13380

Closed Omega359 closed 1 week ago

Omega359 commented 1 week ago

Which issue does this PR close?

Closes #13379

Rationale for this change

Completing support for StringView in udfs

What changes are included in this PR?

Code, tests.

Are these changes tested?

yes

Are there any user-facing changes?

No

jayzhan211 commented 1 week ago

Can you use other signature instead of maintain the list of types with Uniform? Similar to the idea I attempt for https://github.com/apache/datafusion/pull/13356

Omega359 commented 1 week ago

I would but I would prefer if that ticket landed before this one then I could just handle the conflict. I'd rather not mix updating the type signature code and this PR in one