search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
6.37k stars 1.2k forks source link

Add support for utf8view to nvl function #13382

Closed Omega359 closed 1 week ago

Omega359 commented 1 week ago

Which issue does this PR close?

Closes #13381

Rationale for this change

Completing support for StringView in udfs

What changes are included in this PR?

Code, tests

Are these changes tested?

Yes

Are there any user-facing changes?

No

jayzhan211 commented 1 week ago

Can you use other signature instead of maintain the list of types with Uniform? Similar to the idea I attempt for https://github.com/apache/datafusion/pull/13356

I'm thinking of fixing the signature like exact and uniform to a better one #13301

alamb commented 1 week ago

I merged this PR up to resolve a conflict:

Screenshot 2024-11-14 at 4 10 26 PM