Closed alamb closed 1 week ago
There are actually several related "BuiltInWindowExpr" in physical-expr that need to be cleaned up as well (that are no longer related to BuiltInWindowExprs). We may also be able to remove a level of trait.
@alamb @buraksenn @Omega359 Pretty sure we can now clean up the old window docs, due to the nth_value migration being merged. Lemme see if I can do that really quick
@alamb @buraksenn @Omega359 Pretty sure we can now clean up the old window docs, due to the nth_value migration being merged. Lemme see if I can do that really quick
Yes, we can -- I think that is tracked by
LGTM 👍. Thanks @alamb
Thanks @crepererum and @jcsherin for the reviews
Which issue does this PR close?
Rationale for this change
@buraksen and @jcsherin ported the last window function over, so now we can remove the old BuiltInWindowFunction code
This was so tempting a cleanup that I had to give it a try (and I wanted to do some coding)
What changes are included in this PR?
Changes:
BuiltInWindowFunction
BuiltInWindowFunctionDefinition::BuiltInWindowFunction
Are these changes tested?
Yes, by existing CI