search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
6.34k stars 1.2k forks source link

feat: Add implicit casting to `TypeSignature::String` #13404

Open jonathanc-n opened 1 week ago

jonathanc-n commented 1 week ago

Which issue does this PR close?

Closes #.

Rationale for this change

13402 #13394 were running into some problems with implicit casting due to TypeSignature::String not dealing with implicit casting properly

What changes are included in this PR?

Added implicit casting to TypeSignature::String

Are these changes tested?

Yes

Are there any user-facing changes?

Omega359 commented 1 week ago

Please remove the changes to regexp_match as that change adds in support for utf8view which breaks that function (see ci output). It's a much larger issue than those changes. See https://github.com/apache/datafusion/issues/11911#issuecomment-2469181899 for some details.

jonathanc-n commented 1 week ago

Will fix this tommorow.

jayzhan211 commented 3 days ago

Mark this as draft as it is not ready for review