Open alamb opened 5 days ago
That is why I return error for now, we can remove the `opt_filter` after couple of months
_Originally posted by @jayzhan211 in https://github.com/apache/datafusion/pull/13463#discussion_r1847462304_
The idea is that the parameter is never used, so we can remove it to simplify GroupsAccumulator implementations.
@jayzhan211s PRs above throws an error if this assumption is not true.
If we haven't hit any errors in a few months, we should just remove the parameter entirely
_Originally posted by @jayzhan211 in https://github.com/apache/datafusion/pull/13463#discussion_r1847462304_
The idea is that the parameter is never used, so we can remove it to simplify GroupsAccumulator implementations.
@jayzhan211s PRs above throws an error if this assumption is not true.
If we haven't hit any errors in a few months, we should just remove the parameter entirely