search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
6.39k stars 1.21k forks source link

crates.io page has broken logo #13526

Open alamb opened 1 week ago

alamb commented 1 week ago

Describe the bug

https://crates.io/crates/datafusion/43.0.0 apache datafusion logo is missing

Screenshot 2024-11-22 at 9 58 38 AM

To Reproduce

not sure

Expected behavior

The logo should be like https://datafusion.apache.org/

Screenshot 2024-11-22 at 10 00 20 AM

Additional context

No response

Eason0729 commented 4 days ago

https://github.com/apache/datafusion/raw/HEAD/datafusion/core/docs/source/_static/images/2x_bgwhite_original.png was found in crate.io. https://github.com/apache/datafusion/raw/HEAD/docs/source/_static/images/2x_bgwhite_original.png is the correct one.

The logo is missing because readme = "../../README.md" in datafusion/core/Cargo.toml.

If image ./static/image.png was specified, in this case crates.io resolve path to datafusion/core/static/image.png, but static/image.png is what we would like is static/image.png

Possible solution:

  1. use absolute path
  2. maintain a separate README.md for crate.io(create datafusion/core/README.md and readme = "./README.md")

I prefer first one, and I could open a PR if you agree.

Also, I thinks it's an good first issue, so I can also leave it to other if missing logo is not an serious problem

alamb commented 4 days ago

I prefer first one, and I could open a PR if you agree.

I agree. Thank you 🐰

Also, I thinks it's an good first issue, so I can also leave it to other if missing logo is not an serious problem

Good call -- I added the tag. I defer to you if you want to fix it.