search

apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
6.04k stars 1.14k forks source link

Add datafusion-cli to the workspace #3077

Open andygrove opened 2 years ago

andygrove commented 2 years ago

Is your feature request related to a problem or challenge? Please describe what you are trying to do. The CLI Cargo.lock is nearly always out of date because the CLI is not part of the workspace. We have to update it periodically.

Why don't we add datafusion-cli to the workspace, as we did recently in Ballista? https://github.com/apache/arrow-ballista/pull/89

Describe the solution you'd like Add datafusion-cli to workspace

Describe alternatives you've considered None

Additional context None

alamb commented 2 years ago

I think the idea of pinning the Cargo.lock for datafusion-cli was from https://github.com/apache/arrow-datafusion/issues/2071 / https://github.com/apache/arrow-datafusion/pull/2112 and @happysalada

I don't have a strong preference to be honest, as I normally run datafusion-cli from my local checkout

happysalada commented 2 years ago

At the time of that PR, the crate had been yanked. If there is no way to get a source with the cargo lock, it makes maintaining for distributions more work. Ideally there is at least one source with a lockfile. Feel free to ignore this, as I would personally give priority to ease of maintaining.