Open alamb opened 1 year ago
While reviewing https://github.com/apache/arrow-datafusion/pull/7708 from @sarutak I spent time looking into what plan_q does and it is not at all clear to me it needs to be built in release mode:
plan_q
https://github.com/apache/arrow-datafusion/blob/46cdb8c2dc495e8063a0adc5c3f9ac82b136e72e/benchmarks/src/tpch/run.rs#L297-L453
Since the benchmark verifies the plans (rather than actually running them). I think it is ok to use debug mode (rather than release) mode which compiles faster and will have more reuse with the subsequent call to cargo test --test sqllogictests
cargo test --test sqllogictests
No response
I see -- the issue appears to be that non release build overflows the stackL
I will add a comment to the file about this rationale
Is your feature request related to a problem or challenge?
While reviewing https://github.com/apache/arrow-datafusion/pull/7708 from @sarutak I spent time looking into what
plan_q
does and it is not at all clear to me it needs to be built in release mode:https://github.com/apache/arrow-datafusion/blob/46cdb8c2dc495e8063a0adc5c3f9ac82b136e72e/benchmarks/src/tpch/run.rs#L297-L453
Describe the solution you'd like
Since the benchmark verifies the plans (rather than actually running them). I think it is ok to use debug mode (rather than release) mode which compiles faster and will have more reuse with the subsequent call to
cargo test --test sqllogictests
Describe alternatives you've considered
No response
Additional context
No response