apache / datafusion

Apache DataFusion SQL Query Engine
https://datafusion.apache.org/
Apache License 2.0
6.37k stars 1.2k forks source link

Improve `verify benchmark results` time (even) more by using debug (rather than release) build #7709

Open alamb opened 1 year ago

alamb commented 1 year ago

Is your feature request related to a problem or challenge?

While reviewing https://github.com/apache/arrow-datafusion/pull/7708 from @sarutak I spent time looking into what plan_q does and it is not at all clear to me it needs to be built in release mode:

https://github.com/apache/arrow-datafusion/blob/46cdb8c2dc495e8063a0adc5c3f9ac82b136e72e/benchmarks/src/tpch/run.rs#L297-L453

Describe the solution you'd like

Since the benchmark verifies the plans (rather than actually running them). I think it is ok to use debug mode (rather than release) mode which compiles faster and will have more reuse with the subsequent call to cargo test --test sqllogictests

Describe alternatives you've considered

No response

Additional context

No response

alamb commented 1 year ago

I see -- the issue appears to be that non release build overflows the stackL

Screenshot 2023-10-01 at 7 27 07 AM

I will add a comment to the file about this rationale