fix comparison bug since type uint8_t is always non-negative

apache / datasketches-cpp

Core C++ Sketch Library

https://datasketches.apache.org

Apache License 2.0

225 stars 71 forks source link

fix comparison bug since type uint8_t is always non-negative #291

Closed dyf6372 closed 2 years ago

dyf6372 commented 2 years ago

The type of newShiftedVal is uint8_t, so the condition newShiftedVal < 0 is always false.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2630900564

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 92.324%

Files with Coverage Reduction	New Missed Lines	%
hll/include/Hll4Array-internal.hpp	1	91.78%
<!--	Total:	1		-->

Totals
Change from base Build 2516564597:	-0.04%
Covered Lines:	2189
Relevant Lines:	2371

💛 - Coveralls

AlexanderSaydakov commented 2 years ago

I am not sure why Python build on Windows failed

dyf6372 commented 2 years ago

I am not sure why Python build on Windows failed

I'm also confused.

jmalkin commented 2 years ago

It is unrelated to this change.

The Windows python build has an issue affecting all branches currently. It can possibly be resolved by fixing a version of some package but it's not yet clear which one. Alternatively there's a separate issue around what's included in our wheel and it's possible there's now a conflict? Hoping I'll be able to investigate next week.

If everything here works other than the Windows python CI tests we can consider it ok to merge as far as I'm concerned.