apache / datasketches-cpp

Core C++ Sketch Library
https://datasketches.apache.org
Apache License 2.0
223 stars 71 forks source link

Explicitly cast constant uint64_ts that lose precision. #327

Closed jbapple closed 1 year ago

jbapple commented 1 year ago

In clang-16, there are warnings like this upon build:

warning: implicit conversion from 'const uint64_t' (aka 'const
unsigned long') to 'double' changes value from 9223372036854775807
to 9223372036854775808 [-Wimplicit-const-int-float-conversion]

Explicit casting fixes those warnings.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3876955097


Totals Coverage Status
Change from base Build 3876432800: 0.002%
Covered Lines: 2328
Relevant Lines: 2480

💛 - Coveralls