Closed jbapple closed 1 year ago
Totals | |
---|---|
Change from base Build 4027761243: | 0.0% |
Covered Lines: | 2328 |
Relevant Lines: | 2480 |
I feel like it might be worth doing this for the other macros, too?
Alternatively, would it make more sense to make this a namedspaced c++ thing?
I feel like it might be worth doing this for the other macros, too?
Done.
Alternatively, would it make more sense to make this a namedspaced c++ thing?
ROTL64
and CSA
(new in this commit) could be replaced by inline functions, which could be namespaced. The others cannot.
I was thinking that we could alternatively restructure as a proper C++ class, but this certainly works for now and does improve naming safety. Thank you!
. . . by removing one macro and prefacing the other with the logical module it's associated with.