coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 4177834650
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 97.141%
| Totals | |
|---|---|
| Change from base Build 4148972480: | 0.0% |
| Covered Lines: | 4927 |
| Relevant Lines: | 5072 |
Our quantiles algorithms aren't the most compact, but they do benefit from being fully value-agnostic -- to the point where all we require is a less-than comparator. We've had support for generic items in Java and C++, and this should add it for python.
I had to change a couple uses of std::to_string() in the non-python legacy quantiles implementation to use the ostream operator. I believe this is safe and does not change the API since std::to_string() can't be overridden and the types for which it works also have an ostream operator defined. No need for a major version bump as a result of this PR.