apache / datasketches-cpp

Core C++ Sketch Library
https://datasketches.apache.org
Apache License 2.0
225 stars 71 forks source link

Changed family id to 18 #360

Closed c-dickens closed 1 year ago

c-dickens commented 1 year ago

Changed the family id to 18 as per issue: # 359

c-dickens commented 1 year ago

Actually, I don't think this is correct. Changing the family id causes the header to change so the acceptable parameters in check_header_validity need to change accordingly.

jmalkin commented 1 year ago

I think you identified the issue in check_header_validity but didn't get a chance to fix it yet?

jmalkin commented 1 year ago

it worked when i used:

    case 138 : break; // !empty, ser_ver==1, family==18, preLongs=2;
    case 139 : break; // empty, ser_ver==1, family==18, preLongs=2;
    //case 170 : break ; // !empty, ser_ver==1, family==18, preLongs=3 ;
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4734539326


Totals Coverage Status
Change from base Build 4683758529: 0.0%
Covered Lines: 5072
Relevant Lines: 5228

💛 - Coveralls