One more instance of std::iterator deprecation warning in 4.1.0

[ankane]

Hi, thanks for this library!

Just upgraded to 4.1.0 and found one more instance of inheritance from std::iterator (re #328 and #342).

/Users/runner/work/datasketches-ruby/datasketches-ruby/vendor/datasketches-cpp/theta/include/theta_sketch.hpp:474:82: warning: 'iterator<std::input_iterator_tag, unsigned long long>' is deprecated [-Wdeprecated-declarations]
class wrapped_compact_theta_sketch_alloc<Allocator>::const_iterator: public std::iterator<std::input_iterator_tag, uint64_t> {
                                                                                 ^
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__iterator/iterator.h:27:29: note: 'iterator<std::input_iterator_tag, unsigned long long>' has been explicitly marked deprecated here
struct _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX17 iterator
                            ^
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__config:1066:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX17'
#  define _LIBCPP_DEPRECATED_IN_CXX17 _LIBCPP_DEPRECATED
                                      ^
/Applications/Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__config:1043:48: note: expanded from macro '_LIBCPP_DEPRECATED'
#    define _LIBCPP_DEPRECATED __attribute__ ((deprecated))
                                               ^
1 warning generated.

[jmalkin]

D'oh! Thanks for catching this. I thought we'd checked all of them!

😭

[jmalkin]

Fix is merged. We're trying to decide if we need a 4.1.1 patch release or if it's ok to live with this as a warning until 4.2.0 (which has received no planning).

[ankane]

Great, thanks @jmalkin! No strong opinion on a release (fwiw).