apache / datasketches-cpp

Core C++ Sketch Library
https://datasketches.apache.org
Apache License 2.0
213 stars 70 forks source link

Fix UBSan report while compiling with clang-18 #432

Closed alexey-milovidov closed 1 month ago

alexey-milovidov commented 1 month ago

This is a benign report. But clang-18 started to complain.

See https://github.com/ClickHouse/ClickHouse/issues/63858

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9103733837

Details


Totals Coverage Status
Change from base Build 9038987381: 0.0%
Covered Lines: 16427
Relevant Lines: 16599

💛 - Coveralls
jmalkin commented 1 month ago

This makes sense. I don't think the existing code is unsafe, but UBSan has trouble determining that and (validly) complains.