Closed leerho closed 2 months ago
Changes by file:
/kll/
KllDirectCompactItemsSketch
KllDoublesSketch
KllFloatsSketch
KllHeapDoublesSketch
KllItemsSketch
KllMemoryValidate
/quantiles/
DoublesSketch
ItemsUtil
/quantilescommon/
DoublesSketchSortedView
Revised the main constructor to include Min/Max fix.
Added separate test constructor also with Min/Max fix
Removed unneeded class members for min/max
FloatsSketchSortedView
Revised the main constructor to include Min/Max fix.
Added separate test constructor also with Min/Max fix
Removed unneeded class members for min/max
GenericSortedView
IncludeMinMax
ItemsSketchSortedView
Revised the main constructor to include Min/Max fix.
Added separate test constructor also with Min/Max fix
Removed unneeded class members for min/max
/req/
ReqSketch
/test/...
/kll/
KllDirectCompactItemsSketch
KllMiscDoublesTest
Redesigned a test to accommodate new min/max adjustments
Apply "/n" to "LS" corrections
KllMiscFloatsTest
Redesigned a test to accommodate new min/max adjustments
Apply "/n" to "LS" corrections
KllMiscItemsTest
Redesigned a test to accommodate new min/max adjustments
Apply "/n" to "LS" corrections
/quantilescommon/
IncludeMinMaxTest
We changed the behavior of the sorted view to ensure the min and max values are always represented, which, we believe, will provide a more practical information to users of these distributions without distorting the resulting data. -- @jmalkin
Also fixed a problem I discovered in the deserialization for Boolean quantiles, but it would also have shown up with other types. The data was ok, but the max value would have been incorrect.
Also fixed some problems with some of the tests.
Along the way I also replaced "back-slash-n" with platform independent "LS" in the files I touched.
Also moved some functions like getCDF(..) and getPMF(...) into parent interfaces as default functions. Now the three parent interfaces for Doubles SV, Floats SV and Items SV are all code-parallel.