apache / datasketches-java

A software library of stochastic streaming algorithms, a.k.a. sketches.
https://datasketches.apache.org
Apache License 2.0
893 stars 209 forks source link

Add native longs KLL sketch #556

Closed ZacBlanco closed 4 months ago

ZacBlanco commented 5 months ago

Our use case would benefit from an implementation for this native type. I considered a commit to refactor some common logic, but found little benefit, so opted to essentially sed s/float/long/ the KllFloatsSketch implementation along with all of the associated classes and tests.

leerho commented 4 months ago

I haven't had a chance to review this carefully, but I will. In principle I am in favor of this.

jmalkin commented 4 months ago

It's not an elegant solution, but effectively doing s/float/long/g is, sadly, a fairly reasonable approach in Java.

leerho commented 4 months ago

Merge into branch "kll_longs_sketch"