apache / datasketches-postgresql

PostgreSQL extension providing approximate algorithms based on apache/datasketches-cpp
https://datasketches.apache.org
Apache License 2.0
85 stars 11 forks source link

compatible version of datasketches-cpp? #53

Closed cswarth closed 1 year ago

cswarth commented 1 year ago

How can I determine which version of datasketches-cpp datasketches-postgres is compatible with? The README seems to leave that information out.

E.G. current src/kll_float_sketch_c_adapter.cpp references kll_sketch template with 4 parameters.

using kll_float_sketch = datasketches::kll_sketch<float, std::less<float>, datasketches::serde<float>, palloc_allocator<float>>;

But the current kll_sketch.hpp in datasketches-cpp repo has only three parameters,

template <
  typename T,
  typename C = std::less<T>, // strict weak ordering function (see C++ named requirements: Compare)
  typename A = std::allocator<T>
>
class kll_sketch {

Obviously datasketches-postgres is not compatible and cannot compile with this version of datasketches?

cswarth commented 1 year ago

found this in package.sh. I'll try that version of datasketches-cpp

# version of datasketches-cpp core library to include
CORETAG=3.4.0
cswarth commented 1 year ago

NVM, downloaded PGXN package that includes everything needed.