apache / directory-scimple

Apache Directory - SCIMple
https://directory.apache.org/scimple/
Apache License 2.0
66 stars 38 forks source link

Not implementing RFC 7644 3.4.2 and 3.4.3 #553

Closed fc-business-beat closed 5 months ago

fc-business-beat commented 5 months ago

As far as my understanding of the spec goes https://datatracker.ietf.org/doc/html/rfc7644#section-3.4.2 and https://datatracker.ietf.org/doc/html/rfc7644#section-3.4.3 are not implemented yet.

bdemers commented 5 months ago

Thanks for reaching out @fc-business-beat Can you provide more detail on what you are asking about? Stack Overflow has a great article that suggestions what to include in an post: https://stackoverflow.com/help/how-to-ask

That said, 3.4.2 is implemented here: https://github.com/apache/directory-scimple/blob/develop/scim-server/src/main/java/org/apache/directory/scim/server/rest/BaseResourceTypeResourceImpl.java#L150-L169

And 3.4.3 here: https://github.com/apache/directory-scimple/blob/develop/scim-server/src/main/java/org/apache/directory/scim/server/rest/BaseResourceTypeResourceImpl.java#L205

The interface that defines these methods, does have default methods that return:

return Response.status(Status.NOT_IMPLEMENTED).build();

But the implementations do have those methods. I'm not sure if this was causing the confusion, or if it's something else. Please let us know!

fc-business-beat commented 5 months ago

Thank you so much for the quick response! I suppose spring server example and my IDE not creating the methods when implementing the interface made me think it was missing.

Can you please point me towards how i would override these in my ScimGroupService implements Repository and ScimUserService implements Repository? Or am i mixing up client and resource server requirements?

bdemers commented 5 months ago

The SCIMple framework will map the REST request automatically to the corresponding Repository method. All you need to do is implement the Repository.

Does that help?

fc-business-beat commented 5 months ago

I think i got it, thanks a lot!