apache / distributedlog

Apache DistributedLog
Apache License 2.0
185 stars 74 forks source link

Enable LogRecord ByteBuf based constructor public #181

Closed ArvinDevel closed 7 years ago

ArvinDevel commented 7 years ago

Is this a question, feature request, or bug report? feature request

FEATURE REQUEST

  1. Please describe the feature you are requesting. Enable LogRecord ByteBuf based constructor public.

  2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue? should-have

  3. Provide any additional detail on your proposed use case for this feature. I want to use ByteBuf data to construct LogRecord to leverage Dlog's zero-copy feature, but found that constructor still has protected modifier, so I can't access it outside Dlog.

  4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task: None

ArvinDevel commented 7 years ago

pr #182 is the solution.