search

apache / distributedlog

Apache DistributedLog
Apache License 2.0
185 stars 74 forks source link

Issue-165: Enable checkstyle in core module #192

Closed ArvinDevel closed 6 years ago

ArvinDevel commented 7 years ago

Descriptions of the changes in this PR:

Fix checkstyle error in core module

Be sure to do all of the following to help us incorporate your contribution quickly and easily:

  • [ ] Make sure the PR title is formatted like: <Issue-# or DL-#>: Description of pull request e.g. Issue-123: Description ... e.g. DL-1234: Description ...
  • [ ] Make sure tests pass via mvn clean apache-rat:check install findbugs:check.
  • [ ] Replace '#' with in <Issue-# or DL-#> in the title with the actual Issue/JIRA number.
zhaijack commented 6 years ago

This is great job, but seems CI job checks failed. @ArvinDevel Would you please help check if they are related?

ArvinDevel commented 6 years ago

The failed case in CI is "TestBKDistributedLogManager.deleteDuringRead » DLIllegalState Inconsistent sta...", which is passed in my local test. I checkout that Test Class, this PR doesn't change its basic logic, just some style revision. Is there a way to run CI task again, without new pushing action.

sijie commented 6 years ago

@jiazhai @ArvinDevel I think that is a known fail issue. it is probably not related to this pull request. but it is worth creating an issue for tracking it.