search

apache / distributedlog

Apache DistributedLog
Apache License 2.0
185 stars 74 forks source link

BKLogWriteHandler use wrong log name #213

Closed shoukunhuai closed 6 years ago

shoukunhuai commented 6 years ago

I see slf4j log from BKLogWriterHandler is using log name BKLogReaderHandler

2017-10-13 16:46:18,791 INFO [org.apache.distributedlog.BKLogReadHandler] - Initiating Recovery For omsq: : [] 2017-10-13 16:46:18,817 INFO [org.apache.distributedlog.BKLogReadHandler] - Initiating Recovery For omsq: : [] ... 2017-10-13 16:46:42,293 INFO [org.apache.distributedlog.BKLogReadHandler] - No max ledger sequence number found while creating log segment 1 for omsq:. ... 2017-10-13 16:46:42,862 INFO [org.apache.distributedlog.BKLogReadHandler] - Deleting log segments older than 1507625202853 for omsq: : []

May be a mistake ?

sijie commented 6 years ago

@shoukunhuai nice catch! BKLogWriterHandler is using a wrong class name for its logger : https://github.com/apache/distributedlog/blob/master/distributedlog-core/src/main/java/org/apache/distributedlog/BKLogWriteHandler.java#L86

I am wondering if you are interested in sending a pull request to fix it.

shoukunhuai commented 6 years ago

@sijie i opened #215 , please help merge it.

sijie commented 6 years ago

@shoukunhuai merged. thank you for your contribution.