search

apache / dolphinscheduler-sdk-python

Apache DolphinScheduler Python API, aka PyDolphinscheduler.
https://dolphinscheduler.apache.org/python/main
Apache License 2.0
50 stars 18 forks source link

feat: Add sql_delimiter for sql task before version 320 #115

Closed zhongjiajie closed 11 months ago

zhongjiajie commented 11 months ago

Brief Summary of The Change

close: #107

Pull Request checklist

I confirm that the following checklist has been completed.

codecov-commenter commented 11 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (4.0.x@15cf87d). Learn more about missing BASE report.

Files Patch % Lines
src/pydolphinscheduler/tasks/sql.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.0.x #115 +/- ## ======================================== Coverage ? 90.73% ======================================== Files ? 63 Lines ? 2311 Branches ? 0 ======================================== Hits ? 2097 Misses ? 214 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/115/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/115/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.73% <85.71%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.