apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code
https://dolphinscheduler.apache.org/
Apache License 2.0
12.73k stars 4.58k forks source link

[Improvement][dolphinscheduler-dist] Reduce binary distribution file size #16128

Closed zhuxt2015 closed 3 months ago

zhuxt2015 commented 3 months ago

Purpose of the pull request

16125

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

ruanwenjun commented 3 months ago

+1 if this PR submit to 3.2.2. -1 If this PR submit to dev, since this is not a correct way to solve the dependency issue, only hide the problem.

SbloodyS commented 3 months ago

+1 if this PR submit to 3.2.2. -1 If this PR submit to dev, since this is not a correct way to solve the dependency issue, only hide the problem.

Agreed.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.72%. Comparing base (834c320) to head (ea25013).

:exclamation: Current head ea25013 differs from pull request most recent head 6550763

Please upload reports for the commit 6550763 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #16128 +/- ## ============================================ + Coverage 40.71% 40.72% +0.01% - Complexity 5246 5250 +4 ============================================ Files 1385 1385 Lines 46109 46109 Branches 4923 4923 ============================================ + Hits 18771 18779 +8 + Misses 25412 25403 -9 - Partials 1926 1927 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zhuxt2015 commented 3 months ago
image

@SbloodyS How can I resolve this error

SbloodyS commented 3 months ago
image

@SbloodyS How can I resolve this error

You can try this command locally

./mvnw -B clean install \
          -Dmaven.test.skip \
          -Dmaven.javadoc.skip \
          -Dspotless.skip=true \
          -Pdocker,release -Ddocker.tag=ci
zhuxt2015 commented 3 months ago

re-run CI

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud