Closed caicancai closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 40.71%. Comparing base (
a13eacd
) to head (f7e9849
).:exclamation: Current head f7e9849 differs from pull request most recent head ac3875b
Please upload reports for the commit ac3875b to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
IMHO at least you need to verify the behavior of injected registryClient mock after calling
masterRegistryClient.deregister()
. To make things fully covered, you may also test the exception handling block, which is no necessary in this case though. Simply callingmasterRegistryClient.deregister()
is not a meaningful test case.
Thanks, I will close this pr and see if there is any way to improve it later
Purpose of the pull request
Add deregistryTest on Master moudle
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md