apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code
https://dolphinscheduler.apache.org/
Apache License 2.0
12.4k stars 4.49k forks source link

[Improvement][Worker] Rename workerZKPath to workerRegistryPath #16144

Closed caicancai closed 2 weeks ago

caicancai commented 2 weeks ago

Purpose of the pull request

dolphinscheduler supports several registration services, workerZKPath is misleading and workerRegistryPath is more acceptable

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.70%. Comparing base (a13eacd) to head (99b0a7e).

:exclamation: Current head 99b0a7e differs from pull request most recent head 7c2d0fe

Please upload reports for the commit 7c2d0fe to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #16144 +/- ## ============================================ - Coverage 40.73% 40.70% -0.03% + Complexity 5250 5245 -5 ============================================ Files 1385 1385 Lines 46109 46109 Branches 4923 4923 ============================================ - Hits 18781 18770 -11 - Misses 25401 25412 +11 Partials 1927 1927 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

caicancai commented 2 weeks ago

Please run mvn spotless:apply to format code.

Thank you. Fix