apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code
https://dolphinscheduler.apache.org/
Apache License 2.0
12.4k stars 4.49k forks source link

[Bug] Fix condition task will cause workflow instance failed #16152

Closed ruanwenjun closed 1 week ago

ruanwenjun commented 2 weeks ago

Purpose of the pull request

close https://github.com/apache/dolphinscheduler/issues/16150

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 10.90909% with 49 lines in your changes missing coverage. Please review.

Project coverage is 40.98%. Comparing base (edeb1b2) to head (f0af190).

:exclamation: Current head f0af190 differs from pull request most recent head aa34769

Please upload reports for the commit aa34769 to get more accurate results.

Files Patch % Lines
...ache/dolphinscheduler/dao/entity/TaskInstance.java 0.00% 21 Missing :warning:
.../server/master/runner/WorkflowExecuteRunnable.java 0.00% 13 Missing :warning:
...ster/runner/task/condition/ConditionLogicTask.java 0.00% 6 Missing :warning:
...ask/condition/ConditionLogicTaskPluginFactory.java 0.00% 5 Missing :warning:
...ache/dolphinscheduler/service/utils/DagHelper.java 55.55% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #16152 +/- ## ============================================ - Coverage 41.07% 40.98% -0.09% + Complexity 5155 5146 -9 ============================================ Files 1399 1399 Lines 44856 44844 -12 Branches 4756 4735 -21 ============================================ - Hits 18423 18381 -42 - Misses 24628 24653 +25 - Partials 1805 1810 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 week ago

Quality Gate Failed Quality Gate failed

Failed conditions
11.5% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud