apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code
https://dolphinscheduler.apache.org/
Apache License 2.0
12.4k stars 4.49k forks source link

[DSIP-46] Unify the logic task params data structure between front-end and back-end #16153

Closed ruanwenjun closed 6 days ago

ruanwenjun commented 2 weeks ago

Search before asking

Motivation

The logic task params in backend is not structure, we need to parse the logic params from some fields. This make us to use some extra JSON deserialize code, and make the logic is very hard to maintain.

https://github.com/apache/dolphinscheduler/blob/f0e0395b36bba5977135a3b7b4472b91ec388e50/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskInstance.java#L313-L385

Design Detail

Directly parse the logic task params from task params.

Compatibility, Deprecation, and Migration Plan

compatibility

Test Plan

Code of Conduct

cncws commented 2 weeks ago

Hope this DSIP can solve the problem I had:[Bug] [PyTorch] pythonCommand is not used at runtime, it's always using ${PYTHON_LAUNCHER} #15961

ruanwenjun commented 1 week ago

Hope this DSIP can solve the problem I had:[Bug] [PyTorch] pythonCommand is not used at runtime, it's always using ${PYTHON_LAUNCHER} #15961

This DSIP will not fixed this problem, you need to define a PYTHON_LAUNCHER at your environment