apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code
https://dolphinscheduler.apache.org/
Apache License 2.0
12.4k stars 4.49k forks source link

[Imporvement-16170] Master/Worker registration service log improvement #16166

Closed caicancai closed 2 weeks ago

caicancai commented 2 weeks ago

Purpose of the pull request

close #16170

Brief change log

Master/Worker registration service log improvement

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 41.99328% with 518 lines in your changes missing coverage. Please review.

Project coverage is 41.08%. Comparing base (834c320) to head (d436ac6). Report is 4 commits behind head on dev.

:exclamation: Current head d436ac6 differs from pull request most recent head 92f044c

Please upload reports for the commit 92f044c to get more accurate results.

Files Patch % Lines
...heduler/api/service/impl/ResourcesServiceImpl.java 0.00% 147 Missing :warning:
...nscheduler/api/controller/ResourcesController.java 50.57% 43 Missing :warning:
...scheduler/plugin/storage/s3/S3StorageOperator.java 77.61% 25 Missing and 5 partials :warning:
...pache/dolphinscheduler/common/utils/FileUtils.java 7.40% 25 Missing :warning:
...or/resource/CreateDirectoryRequestTransformer.java 4.16% 23 Missing :warning:
...resource/PagingResourceItemRequestTransformer.java 0.00% 23 Missing :warning:
...duler/plugin/storage/hdfs/HdfsStorageOperator.java 79.79% 18 Missing and 2 partials :warning:
...or/resource/FileFromContentRequestTransformer.java 9.52% 19 Missing :warning:
...api/validator/resource/FileRequestTransformer.java 9.52% 19 Missing :warning:
...apache/dolphinscheduler/api/vo/ResourceItemVO.java 0.00% 14 Missing :warning:
... and 29 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #16166 +/- ## ============================================ + Coverage 40.71% 41.08% +0.37% + Complexity 5246 5156 -90 ============================================ Files 1385 1399 +14 Lines 46109 44859 -1250 Branches 4923 4756 -167 ============================================ - Hits 18771 18430 -341 + Misses 25412 24624 -788 + Partials 1926 1805 -121 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

caishunfeng commented 2 weeks ago

Please link the issue, correct the title prefix to [Imporvement] and add some pr description.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud