apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code
https://dolphinscheduler.apache.org/
Apache License 2.0
12.39k stars 4.49k forks source link

[DSIP-46] Unify the logic task params data structure between front-end and back-end #16193

Closed ruanwenjun closed 4 days ago

ruanwenjun commented 1 week ago

Purpose of the pull request

close https://github.com/apache/dolphinscheduler/issues/16153

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

codecov-commenter commented 6 days ago

Codecov Report

Attention: Patch coverage is 19.44444% with 232 lines in your changes missing coverage. Please review.

Project coverage is 41.31%. Comparing base (f69e064) to head (255e6a4).

:exclamation: Current head 255e6a4 differs from pull request most recent head c3c0103

Please upload reports for the commit c3c0103 to get more accurate results.

Files Patch % Lines
...master/runner/task/switchtask/SwitchLogicTask.java 0.00% 37 Missing :warning:
...ster/runner/task/condition/ConditionLogicTask.java 0.00% 15 Missing :warning:
...ache/dolphinscheduler/service/utils/DagHelper.java 54.54% 8 Missing and 7 partials :warning:
...inscheduler/plugin/task/api/TaskPluginManager.java 33.33% 9 Missing and 1 partial :warning:
.../server/master/runner/WorkflowExecuteRunnable.java 0.00% 9 Missing :warning:
...k/dependent/DependentAsyncTaskExecuteFunction.java 0.00% 8 Missing :warning:
...r/plugin/task/api/parameters/SwitchParameters.java 0.00% 8 Missing :warning:
...subworkflow/SubWorkflowLogicTaskPluginFactory.java 0.00% 6 Missing :warning:
.../task/switchtask/SwitchLogicTaskPluginFactory.java 0.00% 6 Missing :warning:
...lugin/task/api/parameters/DependentParameters.java 0.00% 6 Missing :warning:
... and 64 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #16193 +/- ## ============================================ + Coverage 41.00% 41.31% +0.31% - Complexity 5157 5162 +5 ============================================ Files 1400 1403 +3 Lines 44860 44423 -437 Branches 4747 4721 -26 ============================================ - Hits 18396 18355 -41 + Misses 24658 24264 -394 + Partials 1806 1804 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 days ago

Quality Gate Failed Quality Gate failed

Failed conditions
20.8% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud