apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code
https://dolphinscheduler.apache.org/
Apache License 2.0
12.39k stars 4.49k forks source link

[Fix-16191] Fix task cannot use workflow's environment #16199

Closed ruanwenjun closed 5 days ago

ruanwenjun commented 6 days ago

Purpose of the pull request

close https://github.com/apache/dolphinscheduler/issues/16191

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 45.45455% with 18 lines in your changes missing coverage. Please review.

Project coverage is 41.01%. Comparing base (f0e0395) to head (0cfaf19). Report is 1 commits behind head on dev.

:exclamation: Current head 0cfaf19 differs from pull request most recent head de6a34a

Please upload reports for the commit de6a34a to get more accurate results.

Files Patch % Lines
.../server/master/runner/WorkflowExecuteRunnable.java 0.00% 8 Missing :warning:
...erver/master/runner/StreamTaskExecuteRunnable.java 0.00% 4 Missing :warning:
...uler/server/master/registry/ServerNodeManager.java 0.00% 3 Missing :warning:
...e/dolphinscheduler/dao/utils/EnvironmentUtils.java 80.00% 1 Missing :warning:
...e/dolphinscheduler/dao/utils/WorkerGroupUtils.java 80.00% 1 Missing :warning:
...cheduler/scheduler/quartz/ProcessScheduleTask.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #16199 +/- ## ============================================ - Coverage 41.01% 41.01% -0.01% - Complexity 5149 5157 +8 ============================================ Files 1399 1400 +1 Lines 44877 44860 -17 Branches 4759 4747 -12 ============================================ - Hits 18407 18398 -9 + Misses 24662 24656 -6 + Partials 1808 1806 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 5 days ago

Quality Gate Failed Quality Gate failed

Failed conditions
50.9% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud