apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code
https://dolphinscheduler.apache.org/
Apache License 2.0
12.39k stars 4.49k forks source link

Fix task cannot use workflow's environment (#16199) #16206

Closed ruanwenjun closed 4 days ago

ruanwenjun commented 4 days ago

(cherry picked from commit b34fe4604423ff209e42a6a65ac2e75770625143)

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 45.45455% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (3.2.2-prepare@2f928b1). Learn more about missing BASE report.

:exclamation: Current head b9d1a86 differs from pull request most recent head 21477a2

Please upload reports for the commit 21477a2 to get more accurate results.

Files Patch % Lines
.../server/master/runner/WorkflowExecuteRunnable.java 0.00% 8 Missing :warning:
...erver/master/runner/StreamTaskExecuteRunnable.java 0.00% 4 Missing :warning:
...uler/server/master/registry/ServerNodeManager.java 0.00% 3 Missing :warning:
...e/dolphinscheduler/dao/utils/EnvironmentUtils.java 80.00% 1 Missing :warning:
...e/dolphinscheduler/dao/utils/WorkerGroupUtils.java 80.00% 1 Missing :warning:
...cheduler/scheduler/quartz/ProcessScheduleTask.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3.2.2-prepare #16206 +/- ## ================================================ Coverage ? 40.52% Complexity ? 5221 ================================================ Files ? 1381 Lines ? 46062 Branches ? 4904 ================================================ Hits ? 18666 Misses ? 25469 Partials ? 1927 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 days ago

Quality Gate Failed Quality Gate failed

Failed conditions
40.3% Coverage on New Code (required ≥ 60%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint