[DSIP-57][Audit] Revert PR 14981 code

apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code

https://dolphinscheduler.apache.org/

Apache License 2.0

12.73k stars 4.58k forks source link

[DSIP-57][Audit] Revert PR 14981 code #16370

Closed SbloodyS closed 2 months ago

SbloodyS commented 2 months ago

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

caishunfeng commented 2 months ago

The pr #14981 add the alert event listener, I think it's not same with audit log.

This pr seems to revert it, right? Please correct me if I'm wrong.

Can add some brief change log pr description?

SbloodyS commented 2 months ago

The pr #14981 add the alert event listener, I think it's not same with audit log.

This pr seems to revert it, right? Please correct me if I'm wrong.

Can add some brief change log pr description?

Yes. I've discuss it with @ruanwenjun . Since the current workflow state is refactored in #16327, will add a new workflow state listener after it's merged.

SbloodyS commented 2 months ago

Do we need to revert some doc? I am not sure.

So far I have not found the relevant document...

sonarcloud[bot] commented 2 months ago

Quality Gate failed

Failed conditions
23.5% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud