[Bug] [dolphinscheduler-master] AsyncMasterTask may causing a ramp-up in thread pool invocations - Githubissues

apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code

https://dolphinscheduler.apache.org/

Apache License 2.0

12.73k stars 4.58k forks source link

[Bug] [dolphinscheduler-master] AsyncMasterTask may causing a ramp-up in thread pool invocations #16460

Closed Dyqer closed 1 month ago

Dyqer commented 1 month ago

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

Here are some mistakes about AsyncMasterTask

AsyncTask execute times won't be increased
The timeout unit is incorrect, the timeout was supposed to be in minutes, but in the code, it was set to seconds.
If a dependent task is set with a timeout, its execution frequency will increase as it gets closer to the timeout, it will cause DB down if you have lots tasks.

What you expected to happen

we should schedule master async task with a fixed delay instead of fixed rate to avoid service crashes caused by resource exhaustion

How to reproduce

create some denpendent Task with timeout (like 1 minutes)
watch the execute times for async task execution context.

Anything else

No response

Version

3.2.x

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

SbloodyS commented 1 month ago

cc @ruanwenjun