apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code
https://dolphinscheduler.apache.org/
Apache License 2.0
12.88k stars 4.63k forks source link

[Fix-16464] [pom] fix parent pom plugin config error #16463

Closed chenss-1 closed 3 months ago

chenss-1 commented 3 months ago

fix jacoco-maven-plugin instrument excludes tag config loc error Closes #16464

boring-cyborg[bot] commented 3 months ago

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

chenss-1 commented 3 months ago

Can you describe what issue you have? @chenss-1

in idea parent pom error ,i read this plugin official doc ,find this excludes tag should place instrument‘ configuration

SbloodyS commented 3 months ago

in idea parent pom error ,i read this plugin official doc ,find this excludes tag should place instrument‘ configuration

Can you send the link to the official document you found?

chenss-1 commented 3 months ago

in idea parent pom error ,i read this plugin official doc ,find this excludes tag should place instrument‘ configuration

Can you send the link to the official document you found?

https://www.jacoco.org/jacoco/trunk/doc/instrument-mojo.html https://www.jacoco.org/jacoco/trunk/doc/restore-instrumented-classes-mojo.html

restore only support skip tag , instrument support excludes tag

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

boring-cyborg[bot] commented 3 months ago

Awesome work, congrats on your first merged pull request!