Closed Mighten closed 1 month ago
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
First you need to create a DSIP.
First you need to create a DSIP.
Yes you need to create a DSIP, and provide detailed design, rather then directly submit a PR.
@Mighten Please modify the associated issue number
Failed conditions
36.1% Coverage on New Code (required ≥ 60%)
Closing for no plans to do this.
Purpose of the pull request
This pull request adds user-customized YAML support for Kubernetes Pod task, and aims to close: #16482
16482
Brief change log
YamlUtils
withjackson-dataformat-yaml
(new dependency inpom.xml
)K8sUtils
with default namespace injectionVerify this pull request
This change added tests and can be verified as follows:
YamlUtilsTest
to verifyYamlUtils
K8sUtilsTest
to verify updates forK8sUtils
Manually verified the user-customized YAML task mode using both the web page and IDE output:
Switch on the Custom Template mode, and paste Kubernetes YAML file content:
Conclusion: The user-customized YAML mode works correctly in the frontend.
Online, Start the current workflow and review the log of the current task instance:
Conclusion: The user-customized YAML mode works correctly in the backend.
Review the pod output parameters parsed from the log in the IDE console (these are not listed in the task instance log window):
Conclusion: The user-customized YAML mode correctly parses the output values from the log.