[Bug] [dolphinscheduler-api] LoginHandlerInterceptor.preHandle check session without expire time check

GOODBOY008 commented 2 months ago

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

LoginHandlerInterceptor.preHandle check session without expire time check.

https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/interceptor/LoginHandlerInterceptor.java#L71-L77

What you expected to happen

LoginHandlerInterceptor.preHandle should check session expire time.

How to reproduce

Login dolphinscheduler and you can always access the web-ui.

Anything else

No response

Version

dev

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

GOODBOY008 commented 2 months ago

@ruanwenjun PTAL ,Thank you ~

SbloodyS commented 2 months ago

Session expired time is 7200 seconds by default. It not a bug.

GOODBOY008 commented 2 months ago

Session expired time is 7200 seconds by default. It not a bug.

@SbloodyS But there is no check session expired logic in LoginHandlerInterceptor . I tried this on my local environment, logged into DS, and was still able to operate DS the next day.

SbloodyS commented 2 months ago

After a closer look at the dev branch reveals that the bug does exist.

apache / dolphinscheduler