[Bug] [WorkflowExecutionGraph] Missing implememts in isTaskExecutionRunnableForbidden - Githubissues

apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code

https://dolphinscheduler.apache.org/

Apache License 2.0

12.89k stars 4.63k forks source link

[Bug] [WorkflowExecutionGraph] Missing implememts in isTaskExecutionRunnableForbidden #16813

Closed reele closed 4 days ago

reele commented 6 days ago

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened

https://github.com/apache/dolphinscheduler/blob/9a64534f8cd10622f96bbd10300012ceac36bd92/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/graph/WorkflowExecutionGraph.java#L253-L256

i think there should be a check to determine whether the task definition's flag is NO.

but the task instance entity will remove the flag:

https://github.com/apache/dolphinscheduler/blob/9a64534f8cd10622f96bbd10300012ceac36bd92/dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java#L119-L123

is there a plan or a approach to refactor that?

What you expected to happen

don't run the offline task

How to reproduce

run a workflow with a offline task

Anything else

No response

Version

dev

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct