apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code
https://dolphinscheduler.apache.org/
Apache License 2.0
12.7k stars 4.58k forks source link

[Improvement][login controller] Need password when open in new tab #4418

Closed raiden2012 closed 3 years ago

raiden2012 commented 3 years ago

Describe the question The verification is based on sessionId value stored in both cookie and sessionStorage. The new browser tab always has empty sessionStorage so we need to input password again and again.

What are the current deficiencies and the benefits of improvement

Which version of DolphinScheduler: -[1.3.4]

Describe alternatives you've considered Maybe we can use localStorage instead of sessionStorage to make sessionId available across tabs. (Less secure?) It's a so itchy feature.

Full details see https://blog.guya.net/2015/06/12/sharing-sessionstorage-between-tabs-for-secure-multi-tab-authentication/

chengshiwen commented 3 years ago

In the latest dev branch, this issue has been fixed. Please see #4162.

Maybe the commit 1e5da63 can be cherry-picked into the next release 1.3.5? @lgcareer @dailidong

CalvinKirs commented 3 years ago

fix by #4162