apache / doris-flink-connector

Flink Connector for Apache Doris
https://doris.apache.org/
Apache License 2.0
315 stars 221 forks source link

[improve] modify type judgement statements #405

Closed MaoMiMao closed 3 months ago

MaoMiMao commented 3 months ago

Proposed changes

The typeMismatchMessage method creates a string object describing the error every time, but this object is only used when there is a type mismatch. This impacts performance and memory.

Issue Number: NO

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: No
  2. Has unit tests been added: No Need
  3. Has document been added or modified: No Need
  4. Does it need to update dependencies: No
  5. Are there any changes that cannot be rolled back: No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

JNSimba commented 3 months ago

ci failed, PTAL@MaoMiMao

MaoMiMao commented 3 months ago

@JNSimba Resolved