search

apache / doris

Apache Doris is an easy-to-use, high performance and unified analytics database.
https://doris.apache.org
Apache License 2.0
11.8k stars 3.11k forks source link

[Fix](variant) ignore serialization of nothing type #36997

Closed eldenmoon closed 3 days ago

eldenmoon commented 3 days ago
  1. fix variant should not serialize nothing type
  2. fix unstable cases Issue Number: close #xxx
doris-robot commented 3 days ago

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

eldenmoon commented 3 days ago

run buildall

eldenmoon commented 3 days ago

run buildall

github-actions[bot] commented 3 days ago

clang-tidy review says "All clean, LGTM! :+1:"

doris-robot commented 3 days ago
TPC-H: Total hot run time: 39615 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 86c74fe63145bec50ced08439077a126c24ef360, data reload: false ------ Round 1 ---------------------------------- q1 17615 4336 4230 4230 q2 2023 197 197 197 q3 10465 1206 1136 1136 q4 10203 830 858 830 q5 7485 2607 2528 2528 q6 220 135 132 132 q7 955 592 601 592 q8 9212 2055 2046 2046 q9 8940 6474 6496 6474 q10 8890 3743 3675 3675 q11 435 229 230 229 q12 441 234 232 232 q13 18882 2956 2973 2956 q14 255 220 230 220 q15 518 463 481 463 q16 511 369 369 369 q17 958 659 649 649 q18 7877 7419 7355 7355 q19 5039 1520 1445 1445 q20 647 313 321 313 q21 4829 3215 3971 3215 q22 407 329 333 329 Total cold run time: 116807 ms Total hot run time: 39615 ms ----- Round 2, with runtime_filter_mode=off ----- q1 4357 4259 4499 4259 q2 352 273 267 267 q3 2952 2857 2843 2843 q4 1946 1762 1632 1632 q5 5584 5483 5514 5483 q6 222 125 127 125 q7 2195 1907 1865 1865 q8 3208 3406 3422 3406 q9 8686 8537 8819 8537 q10 4077 3914 3763 3763 q11 584 514 489 489 q12 821 685 615 615 q13 17129 3143 3185 3143 q14 313 305 269 269 q15 535 489 485 485 q16 491 426 443 426 q17 1795 1481 1494 1481 q18 8183 7972 7708 7708 q19 1832 1649 1629 1629 q20 3064 1842 1842 1842 q21 5170 4823 4778 4778 q22 657 560 559 559 Total cold run time: 74153 ms Total hot run time: 55604 ms ```
doris-robot commented 3 days ago
TPC-DS: Total hot run time: 173597 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 86c74fe63145bec50ced08439077a126c24ef360, data reload: false query1 903 376 368 368 query2 6451 2437 2360 2360 query3 6637 206 209 206 query4 18985 17392 17161 17161 query5 3779 473 469 469 query6 257 163 184 163 query7 4576 301 285 285 query8 316 303 294 294 query9 8607 2452 2441 2441 query10 562 286 275 275 query11 10485 10045 9956 9956 query12 118 91 87 87 query13 1651 372 368 368 query14 10211 7547 6970 6970 query15 228 195 186 186 query16 7725 275 277 275 query17 1888 556 543 543 query18 1731 286 278 278 query19 200 163 154 154 query20 90 83 84 83 query21 221 124 125 124 query22 4287 4041 4000 4000 query23 33868 33662 33740 33662 query24 10722 2956 2995 2956 query25 610 403 386 386 query26 706 157 160 157 query27 2270 323 326 323 query28 6111 2207 2188 2188 query29 886 665 621 621 query30 250 163 161 161 query31 957 761 765 761 query32 92 54 56 54 query33 662 299 298 298 query34 873 480 499 480 query35 754 636 659 636 query36 1140 1032 974 974 query37 142 74 74 74 query38 2967 2866 2861 2861 query39 883 935 824 824 query40 212 130 126 126 query41 57 52 52 52 query42 104 100 103 100 query43 606 538 520 520 query44 1077 755 739 739 query45 190 162 163 162 query46 1079 713 722 713 query47 1884 1810 1816 1810 query48 391 307 296 296 query49 879 396 423 396 query50 757 384 387 384 query51 6901 6767 6842 6767 query52 106 94 92 92 query53 361 302 288 288 query54 883 442 438 438 query55 70 74 73 73 query56 281 261 263 261 query57 1138 1049 1051 1049 query58 240 220 249 220 query59 3484 3094 3311 3094 query60 309 271 271 271 query61 90 89 89 89 query62 593 426 459 426 query63 309 290 287 287 query64 8545 2202 1722 1722 query65 3129 3078 3100 3078 query66 767 321 318 318 query67 15621 14851 14882 14851 query68 6391 552 556 552 query69 733 446 421 421 query70 1181 1103 1057 1057 query71 513 276 263 263 query72 8710 5217 5511 5217 query73 826 322 321 321 query74 5843 5533 5432 5432 query75 4753 2657 2641 2641 query76 4318 962 963 962 query77 778 295 295 295 query78 10434 9968 9773 9773 query79 3438 512 525 512 query80 2243 449 466 449 query81 560 215 219 215 query82 736 104 105 104 query83 310 174 168 168 query84 271 89 84 84 query85 1183 278 273 273 query86 411 315 328 315 query87 3283 3077 3106 3077 query88 4328 2350 2329 2329 query89 484 376 372 372 query90 1907 237 185 185 query91 128 99 97 97 query92 62 48 49 48 query93 5083 515 518 515 query94 1186 187 180 180 query95 399 307 308 307 query96 605 263 265 263 query97 3260 3057 3073 3057 query98 214 196 190 190 query99 1190 847 839 839 Total cold run time: 279625 ms Total hot run time: 173597 ms ```
github-actions[bot] commented 3 days ago

PR approved by at least one committer and no changes requested.

github-actions[bot] commented 3 days ago

PR approved by anyone and no changes requested.

doris-robot commented 3 days ago
ClickBench: Total hot run time: 30.53 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 86c74fe63145bec50ced08439077a126c24ef360, data reload: false query1 0.04 0.03 0.04 query2 0.09 0.04 0.03 query3 0.22 0.05 0.05 query4 1.67 0.08 0.09 query5 0.51 0.49 0.50 query6 1.14 0.72 0.71 query7 0.02 0.02 0.01 query8 0.05 0.04 0.05 query9 0.56 0.48 0.48 query10 0.53 0.54 0.53 query11 0.14 0.11 0.11 query12 0.15 0.13 0.12 query13 0.59 0.58 0.60 query14 0.77 0.78 0.76 query15 0.84 0.80 0.82 query16 0.34 0.37 0.37 query17 1.04 1.05 0.95 query18 0.19 0.27 0.24 query19 1.88 1.68 1.74 query20 0.02 0.01 0.01 query21 15.43 0.78 0.66 query22 4.64 6.52 1.88 query23 18.35 1.42 1.33 query24 2.08 0.23 0.22 query25 0.15 0.09 0.10 query26 0.26 0.17 0.18 query27 0.10 0.08 0.08 query28 13.32 1.02 0.99 query29 12.63 3.40 3.38 query30 0.26 0.06 0.06 query31 2.86 0.39 0.38 query32 3.27 0.48 0.48 query33 2.85 2.89 2.92 query34 16.94 4.37 4.40 query35 4.46 4.43 4.44 query36 0.65 0.48 0.47 query37 0.19 0.16 0.16 query38 0.15 0.14 0.14 query39 0.05 0.04 0.03 query40 0.19 0.14 0.15 query41 0.08 0.04 0.05 query42 0.05 0.04 0.04 query43 0.04 0.03 0.04 Total cold run time: 109.79 s Total hot run time: 30.53 s ```