apache / doris

Apache Doris is an easy-to-use, high performance and unified analytics database.
https://doris.apache.org
Apache License 2.0
11.8k stars 3.11k forks source link

[refactor](spill) unify the entry point of spill tasks #37020

Closed mrhhsg closed 17 hours ago

mrhhsg commented 3 days ago

Proposed changes

In this PR, Add SpillRunnable to:

  1. Unify the logic of handling canceled status.
  2. Avoid mem_tracker issue of 'memory_orphan_check failure'.
doris-robot commented 3 days ago

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

mrhhsg commented 3 days ago

run buildall

doris-robot commented 3 days ago
TPC-H: Total hot run time: 39965 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 8a08baedf834d2e58148004392a21242d2bec64b, data reload: false ------ Round 1 ---------------------------------- q1 17887 4954 4318 4318 q2 2010 195 201 195 q3 10529 1174 1101 1101 q4 10225 755 840 755 q5 7485 2625 2669 2625 q6 222 135 138 135 q7 963 599 613 599 q8 9224 2081 2076 2076 q9 8877 6510 6488 6488 q10 9052 3695 3768 3695 q11 454 241 241 241 q12 469 233 237 233 q13 17778 2953 3037 2953 q14 277 226 210 210 q15 524 486 488 486 q16 538 374 375 374 q17 975 693 671 671 q18 8050 7512 7625 7512 q19 5207 1452 1507 1452 q20 672 322 330 322 q21 4836 3856 3188 3188 q22 389 337 336 336 Total cold run time: 116643 ms Total hot run time: 39965 ms ----- Round 2, with runtime_filter_mode=off ----- q1 4372 4250 4277 4250 q2 363 269 271 269 q3 2931 2962 2863 2863 q4 1994 1692 1746 1692 q5 5599 5510 5492 5492 q6 216 126 134 126 q7 2243 1853 1856 1853 q8 3216 3403 3459 3403 q9 8690 8618 8817 8618 q10 4122 3877 3747 3747 q11 585 491 505 491 q12 823 635 669 635 q13 17197 3180 3138 3138 q14 320 262 298 262 q15 517 470 491 470 q16 477 423 436 423 q17 1834 1502 1496 1496 q18 8109 8068 7750 7750 q19 1873 1689 1682 1682 q20 3073 1886 1857 1857 q21 5178 5065 4918 4918 q22 738 543 582 543 Total cold run time: 74470 ms Total hot run time: 55978 ms ```
doris-robot commented 3 days ago
TPC-DS: Total hot run time: 174452 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 8a08baedf834d2e58148004392a21242d2bec64b, data reload: false query1 930 382 379 379 query2 6450 2345 2299 2299 query3 6630 211 209 209 query4 19276 17401 17326 17326 query5 3600 480 473 473 query6 264 167 167 167 query7 4598 288 294 288 query8 318 287 289 287 query9 8610 2479 2445 2445 query10 583 295 278 278 query11 10512 10254 10023 10023 query12 122 90 86 86 query13 1639 384 373 373 query14 10283 7651 7501 7501 query15 236 189 194 189 query16 7885 268 278 268 query17 1880 553 531 531 query18 1951 278 279 278 query19 197 157 154 154 query20 93 85 84 84 query21 223 125 128 125 query22 4455 4339 4062 4062 query23 33935 33645 33771 33645 query24 10931 2883 2877 2877 query25 656 406 397 397 query26 1126 157 166 157 query27 2373 331 337 331 query28 7379 2222 2192 2192 query29 923 650 647 647 query30 264 159 157 157 query31 992 771 755 755 query32 102 54 57 54 query33 777 319 296 296 query34 945 485 500 485 query35 768 680 673 673 query36 1148 993 975 975 query37 145 77 76 76 query38 2944 2867 2829 2829 query39 901 821 798 798 query40 214 133 129 129 query41 59 52 54 52 query42 120 102 102 102 query43 591 544 558 544 query44 1209 761 751 751 query45 194 171 172 171 query46 1095 736 713 713 query47 1880 1784 1783 1783 query48 373 315 305 305 query49 869 511 402 402 query50 768 374 380 374 query51 6918 6830 6794 6794 query52 103 91 96 91 query53 360 294 287 287 query54 919 465 443 443 query55 76 73 74 73 query56 297 259 254 254 query57 1153 1064 1062 1062 query58 245 233 250 233 query59 3616 3007 3254 3007 query60 310 269 272 269 query61 94 92 90 90 query62 617 432 444 432 query63 322 292 289 289 query64 8892 2241 1722 1722 query65 3167 3103 3114 3103 query66 1253 327 323 323 query67 15649 14992 14804 14804 query68 8973 577 567 567 query69 706 495 384 384 query70 1428 1064 1141 1064 query71 510 271 271 271 query72 9461 5259 5539 5259 query73 2267 330 327 327 query74 5982 5533 5539 5533 query75 5750 2652 2673 2652 query76 5161 940 959 940 query77 778 302 289 289 query78 10486 9831 9785 9785 query79 9265 520 521 520 query80 910 486 473 473 query81 557 223 226 223 query82 240 99 100 99 query83 346 171 167 167 query84 268 84 86 84 query85 963 288 318 288 query86 360 313 308 308 query87 3289 3104 3085 3085 query88 4712 2344 2347 2344 query89 528 391 379 379 query90 1949 188 182 182 query91 127 100 98 98 query92 75 53 52 52 query93 6063 525 528 525 query94 1340 190 187 187 query95 407 313 318 313 query96 616 270 260 260 query97 3181 2997 3051 2997 query98 207 207 192 192 query99 1154 839 834 834 Total cold run time: 296466 ms Total hot run time: 174452 ms ```
doris-robot commented 3 days ago
ClickBench: Total hot run time: 30.21 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 8a08baedf834d2e58148004392a21242d2bec64b, data reload: false query1 0.04 0.03 0.03 query2 0.07 0.04 0.05 query3 0.23 0.05 0.06 query4 1.66 0.07 0.10 query5 0.50 0.49 0.49 query6 1.13 0.72 0.72 query7 0.02 0.01 0.01 query8 0.06 0.04 0.04 query9 0.56 0.50 0.50 query10 0.54 0.53 0.56 query11 0.16 0.11 0.11 query12 0.14 0.12 0.12 query13 0.59 0.58 0.61 query14 0.75 0.76 0.80 query15 0.84 0.82 0.80 query16 0.38 0.37 0.37 query17 0.94 0.96 0.98 query18 0.23 0.24 0.24 query19 1.79 1.66 1.67 query20 0.01 0.01 0.01 query21 15.45 0.74 0.66 query22 4.51 7.77 1.61 query23 18.25 1.35 1.28 query24 2.07 0.23 0.23 query25 0.16 0.09 0.09 query26 0.27 0.18 0.18 query27 0.08 0.09 0.08 query28 13.28 1.01 1.01 query29 12.63 3.32 3.32 query30 0.25 0.06 0.05 query31 2.85 0.38 0.39 query32 3.28 0.49 0.47 query33 2.89 2.88 2.90 query34 16.88 4.43 4.49 query35 4.46 4.41 4.47 query36 0.63 0.45 0.48 query37 0.18 0.15 0.14 query38 0.15 0.14 0.14 query39 0.04 0.04 0.04 query40 0.17 0.15 0.14 query41 0.09 0.05 0.04 query42 0.06 0.06 0.05 query43 0.04 0.04 0.04 Total cold run time: 109.31 s Total hot run time: 30.21 s ```
mrhhsg commented 3 days ago

run buildall

doris-robot commented 3 days ago
TPC-H: Total hot run time: 39855 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 92a6702197cc120b84f4486815e6a9ed81dfb0f3, data reload: false ------ Round 1 ---------------------------------- q1 17612 4352 4365 4352 q2 2012 190 191 190 q3 10466 1202 1159 1159 q4 10210 859 805 805 q5 7492 2678 2599 2599 q6 214 133 135 133 q7 943 593 597 593 q8 9225 2065 2063 2063 q9 8970 6506 6494 6494 q10 8996 3710 3747 3710 q11 487 235 239 235 q12 441 229 231 229 q13 17766 3001 2971 2971 q14 275 232 217 217 q15 522 478 483 478 q16 489 373 367 367 q17 955 702 700 700 q18 8111 7408 7320 7320 q19 5514 1505 1430 1430 q20 658 330 324 324 q21 4913 3150 3797 3150 q22 401 336 350 336 Total cold run time: 116672 ms Total hot run time: 39855 ms ----- Round 2, with runtime_filter_mode=off ----- q1 4391 4229 4315 4229 q2 370 272 262 262 q3 2967 2867 2907 2867 q4 2041 1690 1729 1690 q5 5609 5477 5466 5466 q6 226 136 133 133 q7 2234 1882 1837 1837 q8 3249 3402 3421 3402 q9 8655 8620 8788 8620 q10 4137 3889 3757 3757 q11 595 519 520 519 q12 846 675 632 632 q13 15909 3174 3194 3174 q14 304 275 274 274 q15 530 504 486 486 q16 501 426 426 426 q17 1850 1493 1480 1480 q18 8165 7936 7798 7798 q19 1831 1605 1647 1605 q20 2144 1870 1881 1870 q21 5101 4939 4813 4813 q22 631 553 562 553 Total cold run time: 72286 ms Total hot run time: 55893 ms ```
doris-robot commented 3 days ago
TPC-DS: Total hot run time: 175193 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 92a6702197cc120b84f4486815e6a9ed81dfb0f3, data reload: false query1 920 376 378 376 query2 6455 2430 2285 2285 query3 6628 208 220 208 query4 19747 17700 17457 17457 query5 3610 486 471 471 query6 272 188 175 175 query7 4610 288 284 284 query8 291 278 286 278 query9 8781 2452 2452 2452 query10 577 317 279 279 query11 10583 10183 10131 10131 query12 118 90 84 84 query13 1642 399 374 374 query14 10265 7154 6995 6995 query15 233 188 189 188 query16 7752 280 267 267 query17 1884 572 541 541 query18 1960 325 265 265 query19 198 160 153 153 query20 87 81 81 81 query21 203 130 122 122 query22 4440 4297 3990 3990 query23 34063 34092 34090 34090 query24 10878 2952 2835 2835 query25 636 385 388 385 query26 901 154 160 154 query27 2304 326 321 321 query28 6773 2187 2151 2151 query29 913 663 650 650 query30 260 160 153 153 query31 985 757 753 753 query32 91 55 57 55 query33 793 290 288 288 query34 1003 480 499 480 query35 782 661 638 638 query36 1122 978 972 972 query37 144 77 73 73 query38 2985 2826 2816 2816 query39 907 834 854 834 query40 211 132 124 124 query41 52 50 53 50 query42 117 97 100 97 query43 570 550 527 527 query44 1299 758 743 743 query45 192 165 169 165 query46 1088 733 736 733 query47 1892 1783 1767 1767 query48 357 299 304 299 query49 819 400 408 400 query50 769 386 384 384 query51 6941 6828 6857 6828 query52 108 93 88 88 query53 358 300 297 297 query54 881 439 437 437 query55 74 75 72 72 query56 271 264 259 259 query57 1129 1057 1067 1057 query58 242 229 236 229 query59 3377 3237 3048 3048 query60 305 273 273 273 query61 90 121 88 88 query62 611 444 447 444 query63 313 282 289 282 query64 8768 2246 1742 1742 query65 3200 3091 3085 3085 query66 744 329 369 329 query67 15707 15324 15027 15027 query68 4633 567 557 557 query69 567 425 385 385 query70 1136 1089 1143 1089 query71 416 286 270 270 query72 7108 5786 5645 5645 query73 766 324 325 324 query74 5969 5583 5565 5565 query75 3526 2665 2662 2662 query76 2896 953 902 902 query77 629 301 297 297 query78 10361 9906 9814 9814 query79 2599 530 520 520 query80 1988 476 470 470 query81 581 221 223 221 query82 804 106 102 102 query83 299 171 173 171 query84 266 89 84 84 query85 1400 291 330 291 query86 444 328 299 299 query87 3353 3128 3120 3120 query88 4252 2355 2353 2353 query89 482 396 373 373 query90 1746 197 191 191 query91 130 104 99 99 query92 59 47 49 47 query93 1641 519 515 515 query94 1071 201 194 194 query95 407 311 310 310 query96 593 272 265 265 query97 3263 3042 3086 3042 query98 222 201 201 201 query99 1153 837 848 837 Total cold run time: 272041 ms Total hot run time: 175193 ms ```
doris-robot commented 3 days ago
ClickBench: Total hot run time: 30.53 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 92a6702197cc120b84f4486815e6a9ed81dfb0f3, data reload: false query1 0.04 0.03 0.03 query2 0.07 0.04 0.04 query3 0.22 0.05 0.05 query4 1.70 0.06 0.06 query5 0.50 0.50 0.47 query6 1.14 0.73 0.72 query7 0.02 0.02 0.01 query8 0.06 0.05 0.05 query9 0.56 0.50 0.49 query10 0.56 0.55 0.56 query11 0.16 0.11 0.12 query12 0.15 0.13 0.12 query13 0.60 0.59 0.61 query14 0.79 0.78 0.80 query15 0.86 0.83 0.83 query16 0.36 0.37 0.34 query17 1.00 1.05 0.97 query18 0.24 0.25 0.26 query19 1.86 1.73 1.74 query20 0.02 0.01 0.01 query21 15.43 0.74 0.66 query22 5.15 6.85 1.68 query23 18.33 1.31 1.28 query24 2.08 0.22 0.21 query25 0.16 0.08 0.08 query26 0.25 0.18 0.18 query27 0.08 0.08 0.08 query28 13.25 1.02 1.00 query29 13.09 3.32 3.30 query30 0.25 0.07 0.05 query31 2.86 0.38 0.39 query32 3.27 0.46 0.47 query33 2.93 2.98 2.93 query34 16.96 4.47 4.47 query35 4.49 4.50 4.54 query36 0.66 0.46 0.47 query37 0.18 0.15 0.15 query38 0.16 0.15 0.14 query39 0.05 0.04 0.04 query40 0.17 0.14 0.14 query41 0.09 0.05 0.05 query42 0.05 0.05 0.05 query43 0.04 0.05 0.04 Total cold run time: 110.89 s Total hot run time: 30.53 s ```
github-actions[bot] commented 17 hours ago

PR approved by at least one committer and no changes requested.

github-actions[bot] commented 17 hours ago

PR approved by anyone and no changes requested.