apache / doris

Apache Doris is an easy-to-use, high performance and unified analytics database.
https://doris.apache.org
Apache License 2.0
12.38k stars 3.22k forks source link

[Bug](function) fix rpad function return error result #41399

Open zhangstar333 opened 4 days ago

zhangstar333 commented 4 days ago

Proposed changes

have test buffer with reserve and resize function fmt::memory_buffer is dynamic contains not the standard contains in STL it's should call resize function to get more memory, specially when realloc and grow more memory

Snipaste_2024-09-27_14-52-48

doris-robot commented 4 days ago

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website. See Doris Document.

zhangstar333 commented 4 days ago

run buildall

doris-robot commented 4 days ago

TeamCity be ut coverage result: Function Coverage: 37.30% (9627/25811) Line Coverage: 28.71% (79699/277589) Region Coverage: 28.14% (41203/146435) Branch Coverage: 24.75% (20979/84748) Coverage Report: http://coverage.selectdb-in.cc/coverage/ed2ddec0393b75b71b8045324ad1f69b173c45e7_ed2ddec0393b75b71b8045324ad1f69b173c45e7/report/index.html

doris-robot commented 4 days ago
TPC-H: Total hot run time: 40382 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit ed2ddec0393b75b71b8045324ad1f69b173c45e7, data reload: false ------ Round 1 ---------------------------------- q1 17620 7354 7247 7247 q2 2008 279 264 264 q3 11888 1055 1160 1055 q4 10497 706 697 697 q5 7760 2838 2834 2834 q6 237 153 151 151 q7 979 616 610 610 q8 9368 1898 2051 1898 q9 6525 6414 6353 6353 q10 6946 2277 2244 2244 q11 442 248 250 248 q12 413 215 217 215 q13 17756 2967 2927 2927 q14 243 208 213 208 q15 588 528 513 513 q16 629 609 580 580 q17 958 501 554 501 q18 7267 6725 6652 6652 q19 1392 1047 1074 1047 q20 477 208 194 194 q21 3948 3151 2951 2951 q22 1112 1010 993 993 Total cold run time: 109053 ms Total hot run time: 40382 ms ----- Round 2, with runtime_filter_mode=off ----- q1 7279 7182 7163 7163 q2 325 224 225 224 q3 2894 2946 2976 2946 q4 2037 1826 1815 1815 q5 5780 5768 5731 5731 q6 225 148 148 148 q7 2233 1832 1832 1832 q8 3370 3527 3481 3481 q9 8877 8919 8810 8810 q10 3576 3535 3562 3535 q11 572 497 496 496 q12 814 627 653 627 q13 10770 3121 3175 3121 q14 316 270 269 269 q15 574 522 531 522 q16 699 655 655 655 q17 1855 1623 1588 1588 q18 8496 8147 7665 7665 q19 1698 1480 1578 1480 q20 2148 1872 1871 1871 q21 5593 5378 5403 5378 q22 1172 1068 1047 1047 Total cold run time: 71303 ms Total hot run time: 60404 ms ```
doris-robot commented 4 days ago
TPC-DS: Total hot run time: 192345 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ed2ddec0393b75b71b8045324ad1f69b173c45e7, data reload: false query1 846 388 409 388 query2 6229 2098 2070 2070 query3 8684 201 199 199 query4 33608 23559 23504 23504 query5 3386 466 463 463 query6 267 174 161 161 query7 4198 307 311 307 query8 285 219 213 213 query9 9423 2659 2644 2644 query10 455 280 298 280 query11 17560 15098 15230 15098 query12 150 99 97 97 query13 1530 427 406 406 query14 10274 7497 7526 7497 query15 273 179 181 179 query16 7972 457 473 457 query17 1601 616 604 604 query18 2154 319 322 319 query19 385 160 156 156 query20 123 110 120 110 query21 216 103 107 103 query22 4806 4528 4440 4440 query23 35072 34177 34029 34029 query24 11029 2896 2889 2889 query25 643 414 419 414 query26 1159 162 166 162 query27 2581 306 299 299 query28 7650 2430 2410 2410 query29 849 452 434 434 query30 268 151 158 151 query31 1050 801 798 798 query32 97 58 55 55 query33 782 301 302 301 query34 992 497 511 497 query35 880 732 732 732 query36 1155 948 970 948 query37 162 91 88 88 query38 3977 3874 3870 3870 query39 1462 1428 1439 1428 query40 217 100 100 100 query41 53 48 50 48 query42 126 96 94 94 query43 561 488 461 461 query44 1205 808 799 799 query45 198 165 168 165 query46 1213 730 729 729 query47 1934 1813 1815 1813 query48 476 382 375 375 query49 915 420 408 408 query50 876 411 425 411 query51 7088 6933 6900 6900 query52 100 86 92 86 query53 272 187 184 184 query54 1175 472 476 472 query55 82 76 75 75 query56 291 258 277 258 query57 1242 1096 1066 1066 query58 256 240 244 240 query59 3243 3013 3091 3013 query60 284 266 282 266 query61 107 103 101 101 query62 850 653 648 648 query63 228 189 190 189 query64 3975 636 629 629 query65 3262 3212 3170 3170 query66 852 300 311 300 query67 16099 15569 15567 15567 query68 4731 568 573 568 query69 510 305 302 302 query70 1228 1133 1133 1133 query71 367 288 280 280 query72 7434 4111 4164 4111 query73 801 336 347 336 query74 10441 8995 8923 8923 query75 3507 2685 2646 2646 query76 3175 903 939 903 query77 449 302 313 302 query78 10541 9635 9625 9625 query79 3483 609 605 605 query80 1191 463 489 463 query81 577 240 239 239 query82 778 144 144 144 query83 257 142 136 136 query84 264 80 83 80 query85 1901 307 285 285 query86 457 304 309 304 query87 4503 4253 4285 4253 query88 4052 2381 2368 2368 query89 443 292 277 277 query90 2013 191 188 188 query91 182 142 152 142 query92 66 47 50 47 query93 3130 562 543 543 query94 1043 278 304 278 query95 355 258 262 258 query96 685 285 279 279 query97 3264 3083 3104 3083 query98 225 211 192 192 query99 1567 1295 1285 1285 Total cold run time: 305033 ms Total hot run time: 192345 ms ```
doris-robot commented 4 days ago
ClickBench: Total hot run time: 32.56 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ed2ddec0393b75b71b8045324ad1f69b173c45e7, data reload: false query1 0.05 0.04 0.04 query2 0.06 0.03 0.03 query3 0.23 0.06 0.06 query4 1.64 0.10 0.09 query5 0.52 0.50 0.52 query6 1.14 0.72 0.72 query7 0.02 0.02 0.02 query8 0.04 0.04 0.03 query9 0.55 0.51 0.50 query10 0.55 0.55 0.54 query11 0.14 0.11 0.10 query12 0.15 0.11 0.10 query13 0.60 0.59 0.60 query14 2.81 2.74 2.82 query15 0.90 0.84 0.81 query16 0.39 0.39 0.38 query17 0.99 1.03 1.05 query18 0.19 0.20 0.20 query19 1.96 1.86 2.03 query20 0.02 0.01 0.00 query21 15.36 0.60 0.59 query22 2.49 2.13 1.89 query23 17.07 0.84 0.95 query24 2.42 0.80 1.27 query25 0.21 0.16 0.04 query26 0.39 0.15 0.14 query27 0.06 0.04 0.04 query28 11.26 1.09 1.07 query29 12.53 3.27 3.22 query30 0.24 0.07 0.06 query31 2.87 0.39 0.37 query32 3.26 0.49 0.46 query33 3.00 3.01 3.04 query34 17.18 4.51 4.48 query35 4.49 4.45 4.54 query36 0.65 0.48 0.48 query37 0.08 0.05 0.05 query38 0.04 0.03 0.03 query39 0.03 0.02 0.02 query40 0.15 0.13 0.12 query41 0.07 0.02 0.02 query42 0.03 0.02 0.02 query43 0.03 0.03 0.02 Total cold run time: 106.86 s Total hot run time: 32.56 s ```
zhangstar333 commented 4 days ago

run buildall

doris-robot commented 4 days ago

TeamCity be ut coverage result: Function Coverage: 37.30% (9627/25811) Line Coverage: 28.71% (79694/277589) Region Coverage: 28.13% (41193/146437) Branch Coverage: 24.75% (20977/84750) Coverage Report: http://coverage.selectdb-in.cc/coverage/c3fe35012a45d027a93275549470e31b99b7112d_c3fe35012a45d027a93275549470e31b99b7112d/report/index.html

doris-robot commented 4 days ago
TPC-H: Total hot run time: 40608 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c3fe35012a45d027a93275549470e31b99b7112d, data reload: false ------ Round 1 ---------------------------------- q1 17559 7523 7287 7287 q2 2018 274 279 274 q3 12176 1051 1094 1051 q4 10574 700 838 700 q5 7739 2864 2786 2786 q6 237 150 147 147 q7 963 609 612 609 q8 9360 1916 1887 1887 q9 6531 6441 6408 6408 q10 6960 2308 2310 2308 q11 429 252 251 251 q12 404 215 215 215 q13 17775 2997 2999 2997 q14 237 210 210 210 q15 576 543 521 521 q16 641 588 587 587 q17 955 556 574 556 q18 7259 6787 6629 6629 q19 1399 911 997 911 q20 482 202 202 202 q21 3901 3082 3240 3082 q22 1103 990 1002 990 Total cold run time: 109278 ms Total hot run time: 40608 ms ----- Round 2, with runtime_filter_mode=off ----- q1 7250 7230 7260 7230 q2 335 229 225 225 q3 2960 2928 3019 2928 q4 2012 1803 1795 1795 q5 5771 5754 5755 5754 q6 229 146 150 146 q7 2204 1810 1826 1810 q8 3386 3523 3544 3523 q9 8845 8890 8850 8850 q10 3626 3572 3520 3520 q11 577 505 478 478 q12 839 622 647 622 q13 9545 3216 3219 3216 q14 305 274 283 274 q15 572 539 514 514 q16 684 652 647 647 q17 1853 1637 1600 1600 q18 8288 7662 7487 7487 q19 1702 1506 1485 1485 q20 2110 1876 1871 1871 q21 5495 5234 5358 5234 q22 1137 1077 1036 1036 Total cold run time: 69725 ms Total hot run time: 60245 ms ```
doris-robot commented 4 days ago
TPC-DS: Total hot run time: 191229 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c3fe35012a45d027a93275549470e31b99b7112d, data reload: false query1 922 395 405 395 query2 6234 2104 2048 2048 query3 8678 193 211 193 query4 33845 23493 23505 23493 query5 3518 486 452 452 query6 267 183 170 170 query7 4195 302 302 302 query8 293 230 228 228 query9 9550 2635 2652 2635 query10 476 278 285 278 query11 17889 15039 15160 15039 query12 155 99 99 99 query13 1527 423 404 404 query14 9227 7736 7175 7175 query15 266 165 172 165 query16 8047 423 459 423 query17 1685 617 588 588 query18 2105 330 331 330 query19 364 160 152 152 query20 125 114 113 113 query21 223 112 108 108 query22 4951 4667 4701 4667 query23 34944 34182 33845 33845 query24 10986 2814 2759 2759 query25 631 414 412 412 query26 1085 160 165 160 query27 2476 289 295 289 query28 7324 2408 2400 2400 query29 842 429 431 429 query30 273 152 156 152 query31 1039 792 811 792 query32 99 52 54 52 query33 763 294 293 293 query34 914 503 479 479 query35 904 731 730 730 query36 1081 954 950 950 query37 162 89 87 87 query38 3933 3921 3805 3805 query39 1496 1430 1406 1406 query40 204 99 98 98 query41 51 48 48 48 query42 115 99 94 94 query43 537 489 498 489 query44 1280 799 783 783 query45 199 166 163 163 query46 1145 710 705 705 query47 1941 1857 1881 1857 query48 465 372 391 372 query49 905 418 399 399 query50 841 412 404 404 query51 7045 6893 6909 6893 query52 99 90 86 86 query53 256 181 186 181 query54 1122 464 468 464 query55 81 78 76 76 query56 302 252 243 243 query57 1191 1118 1114 1114 query58 228 229 239 229 query59 3203 2962 2934 2934 query60 301 273 269 269 query61 106 103 96 96 query62 852 674 680 674 query63 213 183 181 181 query64 4013 638 603 603 query65 3289 3177 3182 3177 query66 1144 312 305 305 query67 15972 15541 15876 15541 query68 4664 567 554 554 query69 482 289 294 289 query70 1153 1056 1122 1056 query71 349 279 264 264 query72 7159 3974 3903 3903 query73 771 333 350 333 query74 10190 9012 8989 8989 query75 3454 2765 2707 2707 query76 2795 845 1037 845 query77 536 297 296 296 query78 10613 9700 9586 9586 query79 2211 584 584 584 query80 2441 453 447 447 query81 599 239 238 238 query82 698 130 135 130 query83 300 133 140 133 query84 269 79 74 74 query85 1629 309 287 287 query86 437 296 303 296 query87 4442 4303 4347 4303 query88 3156 2361 2345 2345 query89 404 289 281 281 query90 2079 186 186 186 query91 179 143 141 141 query92 62 49 47 47 query93 1865 551 552 551 query94 1164 301 292 292 query95 356 255 253 253 query96 614 277 273 273 query97 3292 3141 3084 3084 query98 219 196 195 195 query99 1534 1325 1292 1292 Total cold run time: 300710 ms Total hot run time: 191229 ms ```
doris-robot commented 4 days ago
ClickBench: Total hot run time: 32.24 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c3fe35012a45d027a93275549470e31b99b7112d, data reload: false query1 0.05 0.05 0.04 query2 0.06 0.03 0.03 query3 0.23 0.06 0.06 query4 1.64 0.10 0.10 query5 0.52 0.49 0.50 query6 1.14 0.74 0.72 query7 0.03 0.02 0.01 query8 0.04 0.03 0.03 query9 0.56 0.50 0.50 query10 0.56 0.56 0.54 query11 0.14 0.10 0.10 query12 0.14 0.11 0.11 query13 0.61 0.59 0.60 query14 2.85 2.74 2.79 query15 0.91 0.83 0.84 query16 0.39 0.38 0.39 query17 1.00 1.03 1.08 query18 0.20 0.19 0.20 query19 1.95 1.83 2.03 query20 0.01 0.00 0.01 query21 15.36 0.57 0.59 query22 2.54 2.54 1.96 query23 17.00 1.05 0.85 query24 3.15 0.47 1.33 query25 0.29 0.17 0.10 query26 0.39 0.13 0.14 query27 0.04 0.03 0.04 query28 10.95 1.08 1.07 query29 12.55 3.22 3.17 query30 0.24 0.05 0.06 query31 2.87 0.38 0.37 query32 3.27 0.47 0.47 query33 2.99 3.03 3.04 query34 16.91 4.47 4.39 query35 4.56 4.52 4.48 query36 0.64 0.50 0.48 query37 0.09 0.06 0.06 query38 0.04 0.03 0.03 query39 0.03 0.02 0.02 query40 0.16 0.13 0.13 query41 0.07 0.02 0.02 query42 0.04 0.02 0.02 query43 0.04 0.04 0.02 Total cold run time: 107.25 s Total hot run time: 32.24 s ```
zhangstar333 commented 1 day ago

run buildall

doris-robot commented 1 day ago

TeamCity be ut coverage result: Function Coverage: 37.32% (9631/25805) Line Coverage: 28.71% (79884/278280) Region Coverage: 28.14% (41290/146749) Branch Coverage: 24.76% (21037/84970) Coverage Report: http://coverage.selectdb-in.cc/coverage/c9d84240ebb9febe0be78cfdda027a1b0e930c1a_c9d84240ebb9febe0be78cfdda027a1b0e930c1a/report/index.html

doris-robot commented 1 day ago
TPC-H: Total hot run time: 40745 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c9d84240ebb9febe0be78cfdda027a1b0e930c1a, data reload: false ------ Round 1 ---------------------------------- q1 17560 7434 7215 7215 q2 2017 300 268 268 q3 11837 1042 1066 1042 q4 10557 739 809 739 q5 7755 2910 2727 2727 q6 238 150 148 148 q7 1019 655 619 619 q8 9355 2025 1960 1960 q9 6560 6443 6425 6425 q10 7001 2311 2273 2273 q11 456 249 258 249 q12 404 222 214 214 q13 17774 3022 3118 3022 q14 250 221 227 221 q15 577 534 516 516 q16 656 600 574 574 q17 987 550 606 550 q18 7217 6680 6692 6680 q19 1350 967 1006 967 q20 474 204 207 204 q21 4045 3173 3141 3141 q22 1099 991 994 991 Total cold run time: 109188 ms Total hot run time: 40745 ms ----- Round 2, with runtime_filter_mode=off ----- q1 7223 7207 7219 7207 q2 338 228 230 228 q3 2988 2908 2970 2908 q4 2072 1820 1813 1813 q5 5783 5719 5781 5719 q6 236 149 148 148 q7 2314 1851 1833 1833 q8 3359 3512 3421 3421 q9 8944 8867 8821 8821 q10 3604 3552 3547 3547 q11 596 485 496 485 q12 868 635 604 604 q13 10714 3206 3177 3177 q14 309 275 280 275 q15 593 520 527 520 q16 681 637 633 633 q17 1850 1613 1600 1600 q18 8276 7641 7419 7419 q19 1695 1556 1517 1517 q20 2132 1913 1894 1894 q21 5538 5502 5355 5355 q22 1118 1052 1049 1049 Total cold run time: 71231 ms Total hot run time: 60173 ms ```
doris-robot commented 1 day ago
TPC-DS: Total hot run time: 191223 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c9d84240ebb9febe0be78cfdda027a1b0e930c1a, data reload: false query1 915 399 394 394 query2 6287 2034 1970 1970 query3 8679 193 200 193 query4 33314 23520 23482 23482 query5 3710 480 480 480 query6 279 175 169 169 query7 4198 312 307 307 query8 293 212 210 210 query9 9376 2668 2690 2668 query10 451 289 269 269 query11 17744 15115 15154 15115 query12 140 102 97 97 query13 1552 437 417 417 query14 9868 7338 7412 7338 query15 261 169 174 169 query16 7822 454 480 454 query17 1631 620 601 601 query18 1867 340 322 322 query19 373 163 154 154 query20 119 110 119 110 query21 216 104 108 104 query22 4602 4544 4367 4367 query23 35257 33859 33974 33859 query24 11059 2857 2858 2857 query25 603 412 405 405 query26 1178 157 161 157 query27 2271 309 304 304 query28 7490 2407 2428 2407 query29 799 442 431 431 query30 259 155 150 150 query31 1031 796 809 796 query32 96 54 54 54 query33 772 302 297 297 query34 909 512 500 500 query35 877 739 769 739 query36 1094 941 965 941 query37 145 86 94 86 query38 3983 3839 3861 3839 query39 1460 1433 1400 1400 query40 212 96 98 96 query41 48 45 47 45 query42 124 97 97 97 query43 535 500 485 485 query44 1176 811 797 797 query45 194 173 164 164 query46 1159 729 712 712 query47 1989 1847 1868 1847 query48 464 359 351 351 query49 961 416 417 416 query50 804 418 410 410 query51 7055 6976 6793 6793 query52 99 87 89 87 query53 253 180 186 180 query54 1223 481 468 468 query55 80 76 79 76 query56 282 268 265 265 query57 1249 1194 1137 1137 query58 232 227 230 227 query59 3263 2976 2849 2849 query60 293 271 255 255 query61 102 99 105 99 query62 893 669 671 669 query63 216 184 181 181 query64 4042 637 621 621 query65 3262 3174 3247 3174 query66 824 326 309 309 query67 15696 15394 15404 15394 query68 4463 563 553 553 query69 516 300 287 287 query70 1190 1123 1117 1117 query71 365 273 271 271 query72 7376 3954 3944 3944 query73 763 337 347 337 query74 10291 8995 8960 8960 query75 3463 2721 2658 2658 query76 2984 957 991 957 query77 477 324 307 307 query78 10493 9652 9566 9566 query79 1892 592 590 590 query80 1201 427 441 427 query81 584 240 243 240 query82 678 134 136 134 query83 242 152 138 138 query84 256 72 79 72 query85 1425 292 283 283 query86 436 305 310 305 query87 4389 4280 4257 4257 query88 3342 2476 2421 2421 query89 408 283 285 283 query90 1969 190 183 183 query91 138 103 109 103 query92 71 49 49 49 query93 2609 540 541 540 query94 1058 293 302 293 query95 346 252 256 252 query96 628 285 288 285 query97 3220 3115 3158 3115 query98 213 197 192 192 query99 1530 1288 1290 1288 Total cold run time: 298726 ms Total hot run time: 191223 ms ```
doris-robot commented 1 day ago
ClickBench: Total hot run time: 32.78 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c9d84240ebb9febe0be78cfdda027a1b0e930c1a, data reload: false query1 0.05 0.05 0.04 query2 0.06 0.02 0.02 query3 0.22 0.06 0.06 query4 1.65 0.10 0.11 query5 0.53 0.49 0.52 query6 1.13 0.74 0.71 query7 0.02 0.01 0.01 query8 0.04 0.03 0.03 query9 0.55 0.49 0.49 query10 0.56 0.56 0.56 query11 0.14 0.10 0.11 query12 0.12 0.11 0.12 query13 0.61 0.59 0.59 query14 2.71 2.83 2.83 query15 0.91 0.83 0.82 query16 0.41 0.38 0.39 query17 1.00 1.04 1.06 query18 0.21 0.20 0.20 query19 1.87 1.89 2.03 query20 0.01 0.01 0.01 query21 15.36 0.61 0.57 query22 2.76 1.94 1.52 query23 17.00 0.91 0.80 query24 2.67 1.36 1.23 query25 0.19 0.14 0.14 query26 0.46 0.14 0.13 query27 0.04 0.04 0.04 query28 10.65 1.09 1.07 query29 12.54 3.26 3.27 query30 0.24 0.06 0.05 query31 2.88 0.37 0.37 query32 3.30 0.47 0.46 query33 2.97 3.01 3.03 query34 16.98 4.41 4.48 query35 4.48 4.50 4.45 query36 0.67 0.49 0.48 query37 0.08 0.07 0.06 query38 0.04 0.03 0.04 query39 0.03 0.02 0.02 query40 0.16 0.13 0.13 query41 0.07 0.02 0.02 query42 0.04 0.02 0.02 query43 0.03 0.03 0.03 Total cold run time: 106.44 s Total hot run time: 32.78 s ```