apache / doris

Apache Doris is an easy-to-use, high performance and unified analytics database.
https://doris.apache.org
Apache License 2.0
12.77k stars 3.29k forks source link

[cleanup](load) remove bvar "g_memtable_input_block_allocated_size" #44304

Open kaijchen opened 2 days ago

kaijchen commented 2 days ago

What problem does this PR solve?

Bvar "g_memtable_input_block_allocated_size" is no longer needed after #40912. Calling allocated_bytes() in Memtable::insert() has some performance penalties. So we should remove it.

Release note

None

Check List (For Author)

Check List (For Reviewer who merge this PR)

doris-robot commented 2 days ago

Thank you for your contribution to Apache Doris. Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?
kaijchen commented 2 days ago

run buildall

github-actions[bot] commented 2 days ago

clang-tidy review says "All clean, LGTM! :+1:"

doris-robot commented 2 days ago

TeamCity be ut coverage result: Function Coverage: 38.02% (9898/26035) Line Coverage: 29.21% (82816/283535) Region Coverage: 28.33% (42514/150055) Branch Coverage: 24.89% (21555/86584) Coverage Report: http://coverage.selectdb-in.cc/coverage/61dc0f3864634f256f8f36771d021b229594f8d1_61dc0f3864634f256f8f36771d021b229594f8d1/report/index.html

github-actions[bot] commented 1 day ago

PR approved by at least one committer and no changes requested.

github-actions[bot] commented 1 day ago

PR approved by anyone and no changes requested.

kaijchen commented 3 hours ago

run buildall

github-actions[bot] commented 3 hours ago

clang-tidy review says "All clean, LGTM! :+1:"

doris-robot commented 3 hours ago

TeamCity be ut coverage result: Function Coverage: 38.30% (9976/26048) Line Coverage: 29.43% (83513/283801) Region Coverage: 28.57% (42960/150354) Branch Coverage: 25.16% (21824/86742) Coverage Report: http://coverage.selectdb-in.cc/coverage/fa648235f8d459bc550624f9a8224180618ce6c1_fa648235f8d459bc550624f9a8224180618ce6c1/report/index.html